Skip to content

Migrate modules/browser#2792

Closed
naman9271 wants to merge 3 commits intojitsi:masterfrom
naman9271:migrate-browser
Closed

Migrate modules/browser#2792
naman9271 wants to merge 3 commits intojitsi:masterfrom
naman9271:migrate-browser

Conversation

@naman9271
Copy link
Contributor

Fixes #2637

  • I started migration of jitsi conference but before that it requires the migration of this file as there are some methods like isFirefox which is unable to detect from browser.
  • and while its migration i faced a same issue like ts compliler unable to detect methods that are defined in '@jitsi/js-utils'

image

@jitsi-jenkins
Copy link

Hi, thanks for your contribution!
If you haven't already done so, could you please make sure you sign our CLA (https://jitsi.org/icla for individuals and https://jitsi.org/ccla for corporations)? We would unfortunately be unable to merge your patch unless we have that piece :(.

@naman9271
Copy link
Contributor Author

@saghul , @jallamsetty1 could you please look into this, like all the OS methods are undetectable by ts-compiler and i have tried directly import the class where th emethods are defined it still not able to detect them......is there anything i am missing
image

@jallamsetty1
Copy link
Member

@saghul , @jallamsetty1 could you please look into this, like all the OS methods are undetectable by ts-compiler and i have tried directly import the class where th emethods are defined it still not able to detect them......is there anything i am missing image

It is because the type definitions for these methods are missing in js-utils. I started migrating BrowserCapabilities to TS but I completely dropped the ball - jitsi/js-utils#69. I will try to get that merged soon so that you can proceed with these changes.

@naman9271
Copy link
Contributor Author

naman9271 commented May 30, 2025

I will try to get that merged soon so that you can proceed with these changes.

Ok, @jallamsetty1 Thanks for the clarification! Let me know once the PR gets merged so I can proceed accordingly.

@naman9271 naman9271 closed this Jun 27, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Migrating Files To Typescript

3 participants