Skip to content

Migrate Rtx modifier #2820

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Migrate Rtx modifier #2820

wants to merge 1 commit into from
+40 −17

Conversation

@naman9271
Copy link
Contributor

Fixes #2637

@jitsi-jenkins
Copy link

Hi, thanks for your contribution!
If you haven't already done so, could you please make sure you sign our CLA (https://jitsi.org/icla for individuals and https://jitsi.org/ccla for corporations)? We would unfortunately be unable to merge your patch unless we have that piece :(.

jallamsetty1
jallamsetty1 reviewed Jul 2, 2025
View reviewed changes
modules/sdp/RtxModifier.ts Outdated
msid?: string;
}

export interface IMLineWrap {
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can we migrate SDPTransformUtil.js to TS first and use its type here instead of creating a separate interface for it. This way we don't run into the risk of the interface and implementation diverging and we don't have to keep updating interface here when the class is modified.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@jallamsetty1 yes sure i have already raised a PR for SDPTransformUtils.js (#2819 ) Please review

@naman9271 naman9271 closed this Jul 12, 2025
@naman9271 naman9271 reopened this Jul 12, 2025
@naman9271
Copy link
Contributor Author

@jallamsetty1 , @saghul conflicts resolved PTAL.

@naman9271
Copy link
Contributor Author

@jallamsetty1 @saghul PTAl.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@jallamsetty1 jallamsetty1 jallamsetty1 left review comments

At least 1 approving review is required to merge this pull request.

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Migrating Files To Typescript

3 participants

@naman9271 @jitsi-jenkins @jallamsetty1