fix(e2ee) Wait for Olm sessions to be established before updating keys#2955
Merged
jallamsetty1 merged 3 commits intomasterfrom Dec 19, 2025
Merged
fix(e2ee) Wait for Olm sessions to be established before updating keys#2955jallamsetty1 merged 3 commits intomasterfrom
jallamsetty1 merged 3 commits intomasterfrom
Conversation
There was a problem hiding this comment.
Pull request overview
Copilot reviewed 3 out of 3 changed files in this pull request and generated 2 comments.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
There was a problem hiding this comment.
Pull request overview
Copilot reviewed 3 out of 3 changed files in this pull request and generated 4 comments.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
535dfdf to
698b9d5
Compare
saghul
approved these changes
Dec 19, 2025
Member
saghul
left a comment
There was a problem hiding this comment.
Left some minor comments, but LGTM overall. Good call on watiting for receiving other participant sessions! I had a local branch implementing pretty much that but yours is more roubust with the timeout and proper cleanup.
1636d31 to
ddf6e42
Compare
catFurr
pushed a commit
to alfaz-studio/lib-jitsi-meet
that referenced
this pull request
Jan 22, 2026
jitsi#2955) * fix(e2ee) Wait for Olm sessions to be established before updating keys * squash: address review feedback * fix(e2ee) Clean up session state when it is disabled
catFurr
pushed a commit
to alfaz-studio/lib-jitsi-meet
that referenced
this pull request
Jan 23, 2026
jitsi#2955) * fix(e2ee) Wait for Olm sessions to be established before updating keys * squash: address review feedback * fix(e2ee) Clean up session state when it is disabled
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.