Skip to content

fix(e2ee) Wait for Olm sessions to be established before updating keys#2955

Merged
jallamsetty1 merged 3 commits intomasterfrom
fix-e2ee
Dec 19, 2025
Merged

fix(e2ee) Wait for Olm sessions to be established before updating keys#2955
jallamsetty1 merged 3 commits intomasterfrom
fix-e2ee

Conversation

@jallamsetty1
Copy link
Member

No description provided.

Copilot AI review requested due to automatic review settings December 18, 2025 16:29
@jallamsetty1 jallamsetty1 marked this pull request as draft December 18, 2025 16:29
Copy link

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot encountered an error and was unable to review this pull request. You can try again by re-requesting a review.

Copy link

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Copilot reviewed 3 out of 3 changed files in this pull request and generated 2 comments.


💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Copy link

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Copilot reviewed 3 out of 3 changed files in this pull request and generated 4 comments.


💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

@jitsi jitsi deleted a comment from Copilot AI Dec 18, 2025
@jitsi jitsi deleted a comment from Copilot AI Dec 18, 2025
Copy link
Member

@saghul saghul left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Left some minor comments, but LGTM overall. Good call on watiting for receiving other participant sessions! I had a local branch implementing pretty much that but yours is more roubust with the timeout and proper cleanup.

@jallamsetty1 jallamsetty1 marked this pull request as ready for review December 19, 2025 16:36
@jallamsetty1 jallamsetty1 merged commit 67fd2c8 into master Dec 19, 2025
2 checks passed
@jallamsetty1 jallamsetty1 deleted the fix-e2ee branch December 19, 2025 19:23
catFurr pushed a commit to alfaz-studio/lib-jitsi-meet that referenced this pull request Jan 22, 2026
jitsi#2955)

* fix(e2ee) Wait for Olm sessions to be established before updating keys

* squash: address review feedback

* fix(e2ee) Clean up session state when it is disabled
catFurr pushed a commit to alfaz-studio/lib-jitsi-meet that referenced this pull request Jan 23, 2026
jitsi#2955)

* fix(e2ee) Wait for Olm sessions to be established before updating keys

* squash: address review feedback

* fix(e2ee) Clean up session state when it is disabled
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants