Use link-time optimization when compiling Opus code.#35
Open
JonathanLennox wants to merge 2 commits intojitsi:mainfrom
Open
Use link-time optimization when compiling Opus code.#35JonathanLennox wants to merge 2 commits intojitsi:mainfrom
JonathanLennox wants to merge 2 commits intojitsi:mainfrom
Conversation
This causes emscripten to build all its dependent libraries with lto, so cache the results of that in order to speed up builds.
.github/workflows/build.yaml
Outdated
| env: | ||
| cache-name: emscripten-cache | ||
| with: | ||
| path: ~/emsdk_main/upstream/emscripten/cache |
Member
There was a problem hiding this comment.
Is this the path we expect to see? The above has emsdk-main rather than emsdk_main
Member
Author
There was a problem hiding this comment.
Yes, you're right; fixed to use ${{ env.EMSDK }}
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This causes emscripten to build all its dependent libraries with lto, so cache the results of that in order to speed up builds.