refactor identity usage#111
Conversation
| startDate: connectionInfo.startDate | ||
| }; | ||
|
|
||
| // Don't process dumps generated by JVB & Jigasi, there should be a more formal process to |
There was a problem hiding this comment.
bellow this line we persist connections that are JVB and JIGASI these do not go through the FeatureExtractor instead they are just saved directly, so the dumpData is still needed at this point.
Also line 77 calls this.persistDumpData(dumpData); I don't see that function defined in this class.
| userRegion | ||
| }; | ||
|
|
||
| if (typeof applicationName !== 'undefined') { |
There was a problem hiding this comment.
with or without the ifs won't this produce the same result? I don't think we need to check each individual value. e.g. we remove the if and the code simply becomes:
this.dumpInfo.conferenceId = confName; this.dumpInfo.app = applicationName; ...
if the values are undefined the values inside dumpInfo will simply be undefined as well which works fine for our purposes. Or do we check somewhere if the actual key exists?
| this.collector = new QualityStatsCollector(this.statsFormat); | ||
| } | ||
|
|
||
| if (typeof connectionInfoJson?.startDate !== 'undefined') { |
There was a problem hiding this comment.
no need to check the typeof simply assign the value to this.dumpInfo.startDate
| * Required when creating mock tests. | ||
| */ | ||
| constructor({ tempPath, dumpFolder, connectionInfo, log, persistDump = false }) { | ||
| constructor({ tempPath, dumpFolder, dumpPath, connectionInfo, log, persistDump = false }) { |
There was a problem hiding this comment.
I think tempPath and dumpFolder are no longer needed if we're going to rely on the newly added dumpPath right?
2 participants
No description provided.