run: Support labeled revisions. - #10051
Conversation
b910d9b to
a89813a
Compare
a89813a to
01322c2
Compare
PhilipMetzger
left a comment
There was a problem hiding this comment.
LGTM. While the mechanism is great we should find better ways to integrate this cc @hooper for a better opinion and the metadata on snapshot proposal
|
Also what happens if multiple labels apply to some revision, such as |
Good point. I'm not yet sure I understand exactly what we want this to look like, so I'll update this then |
db700e7 to
8cd97bf
Compare
This allows users to easily perform comparisons between builds. For example: `jj run -r before=trunk() -r after=@ -- "build && cp out/main /tmp/$JJ_LABEL"` Would generate `/tmp/before` and `/tmp/after`
8cd97bf to
ff34f00
Compare
Previously, `jj run -j2 -r before=main@origin -r after=@` would run the two commits in workspaces 0 and 1 (assuming no other run command was running), but in no particular order. This meant that you could run jj run to build your artifact, then rerun it again and it would potentially swap around the workspaces, requiring a rebuild despite nothing having changed.
ff34f00 to
34c59e1
Compare
|
Looks like the formatter is broken globally |
See #10081. |
This allows users to easily perform comparisons between builds. For example:
jj run -r before=trunk() -r after=@ -- "build && cp out/main /tmp/$JJ_LABEL"Would generate
/tmp/beforeand/tmp/afterChecklist
If applicable:
CHANGELOG.mdREADME.md,docs/,demos/)cli/src/config-schema.json)how it works, how it's organized), including any code drafted by an LLM.
an eye towards deleting anything that is irrelevant, clarifying anything
that is confusing, and adding details that are relevant. This includes,
for example, commit descriptions, PR descriptions, and code comments.