stacked_table: propagate remove_head errors other than NotFound - #10061
Open
petejm wants to merge 1 commit into
Open
stacked_table: propagate remove_head errors other than NotFound#10061petejm wants to merge 1 commit into
petejm wants to merge 1 commit into
Conversation
TableStore::remove_head discarded every error from removing a stale table head marker, not just NotFound. Mirror SimpleOpHeadsStore::remove_op_head, which handles the identical situation correctly: NotFound is tolerated (another process, e.g. on a distributed file system without working locks, may have already removed the head), but any other I/O error (permission denied, full disk, etc.) now propagates via a new TableStoreError::RemoveHeads variant instead of being silently swallowed. Fixes jj-vcs#10060 Assisted-by: Claude:claude-fable-5
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #10060.
TableStore::remove_headintended to tolerate only a missing head marker but discarded every error. It now matchesErrorKind::NotFoundand propagates the rest, mirroringSimpleOpHeadsStore::remove_op_head, which carries the same comment and already implements the intent correctly. Two new tests cover the tolerated NotFound path end-to-end and (unix) propagation of a real removal failure.Checklist
If applicable:
CHANGELOG.mdhow it works, how it's organized), including any code drafted by an LLM.
an eye towards deleting anything that is irrelevant, clarifying anything
that is confusing, and adding details that are relevant. This includes,
for example, commit descriptions, PR descriptions, and code comments.