jj-core: add description to Cargo.toml - #10087
Open
logarithmone1128 wants to merge 1 commit into
Open
Conversation
jj-core was the only package in the workspace without a description, including the two that set publish = false. cargo warns "manifest has no description" when packaging it, and crates.io requires the field, so the crate cannot be published as it stands.
|
Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA). View this failed invocation of the CLA check for more information. For the most up to date status, view the checks section at the bottom of the pull request. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Checklist
If applicable:
CHANGELOG.md— not user-visible, and jj-core: add LICENSE file #10067 did not add an entry for the sibling LICENSE change eitherREADME.md,docs/,demos/) — n/acli/src/config-schema.json) — n/ajj-coreis the only package in the workspace without adescription, includingtestutilsandgen-protos, which setpublish = falseand still have one.cargo package -p jj-corewarns about it today:The warning is gone after this change, and
Cargo.lockis untouched. crates.io requires the field, andjj-coreis publishable — nopublish = false— but not yet on crates.io, so the crate cannot go out as it stands.The wording follows
jj-lib's pattern and reflects what the crate holds: content hashing, DAG walking, diff and merge, matchers, and the path/name/object-id types.I have not reproduced the crates.io rejection itself, only the local
cargo packagewarning;cargo packagestill fails further along for an unrelated reason, sincejj-core-proc-macrosis not on the index yet either.