infra: publish PR previews for docs (second try) #5117
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Diff from the previous version:
|
neongreen
force-pushed
the
push-qtnsouwypwsl
branch
from
26d9d5a to
44132b0
Compare
|
Also, thank you! |
Merged
4 tasks
|
Will hold until #5076 lands |
neongreen
force-pushed
the
push-qtnsouwypwsl
branch
from
44132b0 to
9c4744e
Compare
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
Comment on lines
+23
to
+26
| on: | ||
| workflow_run: | ||
| workflows: [docs-preview-build] | ||
| types: [completed] |
Check failure
Code scanning / zizmor
use of fundamentally insecure workflow trigger Error
There was a problem hiding this comment.
@thoughtpolice I believe this workflow_run is safe but maybe you want to take a look at it
neongreen
force-pushed
the
push-qtnsouwypwsl
branch
from
9c4744e to
79c7871
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Cont. of the accidentally closed #4829
I think it should work. I kinda ran out of steam here so I would appreciate if somebody either tested it or nudged me to re-testUpdate Feb 15: I re-tested and it worksChecklist
If applicable:
CHANGELOG.md