config-schema.json: fixes to the schema #5654
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ilyagr
force-pushed
the
ig/jsonschema
branch
from
331e185 to
d65724d
Compare
ilyagr
force-pushed
the
ig/jsonschema
branch
2 times, most recently
from
c84391d to
3fe24e6
Compare
This makes the schema a bit less smart, but there's a good chance `taplo` could not use "propertyNames" anyway because that comes from a newer version of the schema than `taplo` officially supports (see the child of this commit). Fixes #5607
"$comment" is not officially supported by draft-4, but it is in newer drafts, and JSON schema readers are supposed to skip fields that are not known to them.
ilyagr
force-pushed
the
ig/jsonschema
branch
from
3fe24e6 to
069de14
Compare
thoughtpolice
approved these changes
Feb 11, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #5607 in particular.
This can be thought of as a companion to @steadmon 's #5651.