-
Notifications
You must be signed in to change notification settings - Fork 404
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
ui: add color to help text #5716
base: main
Are you sure you want to change the base?
Conversation
ce534cb
to
b09ca8a
Compare
I personally like the colored styled. Can you remind me why clap4 switched away from it? |
@martinvonz There's no strong justification as far as I can tell beyond "polishing up" - clap-rs/clap#4132 |
819f7ab
to
f75d8cf
Compare
Thanks. I think that's quite well justified, actually. For reference, here's what it says, with some comments from me interleaved:
We use a lot of colors too and some people hate it. So I don't think this argument applies to jj. (We may want to define some kinds of "color scheme" or way of resetting colors without disabling them, but that's mostly unrelated to this PR.)
+1
These are a bit relevant to us. I don't think the default clap colors conflict much with our color scheme. I don't think users are going to interpret the green commands as good and the yellow headings as warnings, for example. It seems reasonable for us to let the user define the colors in So this PR looks good to me, but I'm not going to approve it yet because I think we should give others a chance to comment first. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I don't have strong feeling against the clap's default nor this PR.
04b381d
to
ee098aa
Compare
ee098aa
to
ba2cd1b
Compare
I appreciate that this might not be to everyone's taste, but I find help text output more readable with colours.
I chose the default clap v3 colours since that's what I've become used to with Rust tools, but happy to tweak as desired, or close this PR entirely if the plain appearance is the
jj
maintainers' preference.Before
After
Checklist
If applicable:
CHANGELOG.md