Skip to content

Conversation

AngelEzquerra
Copy link
Contributor

Up until now, trying to get a config value that was an array or a table would fail with an error indicating that only values that can be converted to a string can be displayed. This change fixes that issue by converting arrays and tables into TOML format.

Checklist

If applicable:

  • [ x] I have updated CHANGELOG.md
  • I have updated the documentation (README.md, docs/, demos/)
  • I have updated the config schema (cli/src/config-schema.json)
  • [ x] I have added/updated tests to cover my changes

@AngelEzquerra AngelEzquerra requested a review from a team as a code owner August 31, 2025 18:24
@AngelEzquerra AngelEzquerra force-pushed the config_get_complex_values branch from e564d73 to a72d131 Compare August 31, 2025 18:51
@AngelEzquerra AngelEzquerra force-pushed the config_get_complex_values branch 2 times, most recently from e141f39 to 781cb7e Compare September 6, 2025 12:35
@AngelEzquerra AngelEzquerra force-pushed the config_get_complex_values branch 2 times, most recently from 93b1704 to c8869f9 Compare September 7, 2025 16:43
Up until now, trying to get a config value that was an array or a table would fail with an error indicating that only values that can be converted to a string can be displayed. This change fixes that issue by converting arrays and tables into TOML format.
@AngelEzquerra AngelEzquerra force-pushed the config_get_complex_values branch from c8869f9 to 5622cd3 Compare September 24, 2025 16:33
@AngelEzquerra AngelEzquerra added this pull request to the merge queue Sep 24, 2025
Merged via the queue into jj-vcs:main with commit df2c1ed Sep 24, 2025
29 checks passed
@AngelEzquerra AngelEzquerra deleted the config_get_complex_values branch September 24, 2025 17:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants