nextest: mark local tests that last >10s as slow, increase CI SLOW value #7572
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ilyagr
force-pushed
the
ig/nextest-timeout
branch
from
3b8f64c to
95141a1
Compare
thoughtpolice
approved these changes
Sep 23, 2025
|
Thanks Austin! I'll wait for an out-of-ERSC approval as well. |
martinvonz
reviewed
Sep 23, 2025
This makes it so that tests that last longer than 10s are marked as "SLOW" in nextest UI. This does not terminate them. We already have this enabled in CI, but it seems nice to enable for everybody. On my machine, `test_concurrent_read_write_commit` sometimes deadlocks, and this helps see which test is troublesome. I erred on the side of a higher timeout, following the principle that it's more important that warnings are actionable than to miss some warnings. If somebody is debugging slow tests, they'll know to lower the value. See the CI config or the next commit for what a config that also terminates tests if they run too long looks like.
ilyagr
force-pushed
the
ig/nextest-timeout
branch
2 times, most recently
from
56dd534 to
8a8fbf8
Compare
Previously, nextest marked tests slow in CI when they run for more than 5 seconds. This makes it so that this happens after 10 seconds. I did *not* change the timeout for when tests are actually *terminated* for being too slow. It remains at 100s. It might make sense to increase it (keeping the `terminate-after` multiplier at 10). This is just adjusting to taste, but I find the number of SLOWs in https://github.com/jj-vcs/jj/actions/runs/17843955040/job/50747342340?pr=7549 distracting, and most of the slow tests on Windows last more than 10s anyway. We could also do this only on Windows if people prefer, but I think doing it everywhere is simpler.
ilyagr
force-pushed
the
ig/nextest-timeout
branch
from
8a8fbf8 to
0f5729b
Compare
martinvonz
approved these changes
Sep 24, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.