prev/next: add an error when not using --edit and the working-copy has children #7690
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
glehmann
force-pushed
the
gln/no-edit-children-error-pxlp
branch
from
a77c40b to
2f9af19
Compare
martinvonz
reviewed
Oct 10, 2025
glehmann
force-pushed
the
gln/no-edit-children-error-pxlp
branch
from
2f9af19 to
db7641a
Compare
|
I'm fine with this patch even though I raised some concerns in the aforementioned issue. Maybe this will make it more intuitive to users so LGTM. |
glehmann
force-pushed
the
gln/no-edit-children-error-pxlp
branch
2 times, most recently
from
be6b9ae to
2a47b55
Compare
martinvonz
reviewed
Oct 13, 2025
glehmann
force-pushed
the
gln/no-edit-children-error-pxlp
branch
from
2a47b55 to
8bbaccf
Compare
glehmann
force-pushed
the
gln/no-edit-children-error-pxlp
branch
4 times, most recently
from
b18d0d2 to
6235b23
Compare
…s children We shouldn't be in that case, and it can lead to confusing situations with next completely switching branch. fix: jj-vcs#7046
glehmann
force-pushed
the
gln/no-edit-children-error-pxlp
branch
from
6235b23 to
309a4e7
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We shouldn't be in that case, and it can lead to confusing situations with next completely switching branch.
fix: #7046
Checklist
If applicable:
CHANGELOG.mdREADME.md,docs/,demos/)cli/src/config-schema.json)