-
Notifications
You must be signed in to change notification settings - Fork 750
jj
commands should throw a warning when the fileset does not exist
#7693
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
jj
commands should throw a warning when the fileset does not exist
#7693
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The following commits do not follow our format for subject lines:
Commits should have a subject line following the format <topic>: <description>
. Please review the commit guidelines for more information.
jj status
should throw an error when the fileset does not existjj status
should throw a warning when the fileset does not exist
14e7bbd
to
84fb867
Compare
All commits are now correctly formatted. Thank you for your contribution!
84fb867
to
bea6920
Compare
CHANGELOG.md
Outdated
* `jj status` now throws a warning when the fileset does not exist. | ||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
nit: Please squash this change into the parent commit.
I'm not sure we even need to mention it in the changelog. Users will notice the new warning when they run into it anyway. I can see some small value in having it there e.g. if a user is wondering why they're not seeing the warning when they're on an older version than their friend who is seeing the warning. Then they can check the changelog to see why. If we do add the changelog entry, it would be nice if it was just one entry for all remaining commands (see my other comment), so we don't end up with 10 different entries as we add the warning in new places.
fb17003
to
d6a7b86
Compare
jj status
should throw a warning when the fileset does not existjj
commands should throw a warning when the fileset does not exist
0eeeaac
to
0c2a608
Compare
0c2a608
to
38cfcd1
Compare
38cfcd1
to
5e3fd26
Compare
5e3fd26
to
55ab0d8
Compare
IMO, you should merge the revision that changes the command and the revision that adds the test for each command. It would be easier to review. |
I want to make sure that the warning is shown in a consistent manner across all commands. That's why the commands and tests are one after another. I would be happy to split the PR in whatever way is more convenient for the reviewer when ready :)
I didn't have to add tests for all the commands. Some of them already had tests capturing this behaviour, for example, |
nit: Could you squash the tests into the commit they're testing? See https://jj-vcs.github.io/jj/latest/contributing/#commit-guidelines |
Closes #6556.
Checklist
If applicable:
CHANGELOG.md
README.md
,docs/
,demos/
)cli/src/config-schema.json
)