github: make validation script check to not fail on non-dismissable PRs #7772
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This change prevents the PR workflow (Validate Pull Request) from failing with: > Error: Unhandled error: HttpError: Validation Failed: "Can not > dismiss a dismissed pull request review" We fix this by first checking if the PR is in a dismissable state using latestReview.state === 'CHANGES_REQUESTED'
|
cc @icorbrey since I wanted to ping you on this in the Discord anyway. |
icorbrey
approved these changes
Oct 19, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change prevents the PR workflow (Validate Pull Request) from failing with:
For example, this happens in my other PR: #7704
Here's the workflow that fails:
https://github.com/jj-vcs/jj/actions/runs/18632398780/job/53118936287?pr=7704
In this commit it's fixed by first checking if the PR is in a dismissable state, ie:
latestReview.state === 'CHANGES_REQUESTED'However, I'm not 100% sure this works. I'm not sure what's the best way to test it. Open to ideas :)