Skip to content

Conversation

tbodt
Copy link

@tbodt tbodt commented Oct 20, 2025

#7679

Checklist

If applicable:

  • I have updated CHANGELOG.md
  • I have updated the documentation (README.md, docs/, demos/)
  • I have updated the config schema (cli/src/config-schema.json)
  • I have added/updated tests to cover my changes

@tbodt tbodt requested a review from a team as a code owner October 20, 2025 20:52
Copy link

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The following commits do not follow our format for subject lines:

  • dfbfe57: Add flag and setting to hide untracked files in jj status

Commits should have a subject line following the format <topic>: <description>. Please review the commit guidelines for more information.

@tbodt tbodt force-pushed the push-vsmvzsltktqv branch 2 times, most recently from dfbfe57 to fc95e74 Compare October 20, 2025 20:54
@github-actions github-actions bot dismissed their stale review October 20, 2025 20:54

All commits are now correctly formatted. Thank you for your contribution!

@tbodt tbodt force-pushed the push-vsmvzsltktqv branch from fc95e74 to a2c390a Compare October 20, 2025 20:58
@tbodt tbodt force-pushed the push-vsmvzsltktqv branch from a2c390a to 6544c83 Compare October 20, 2025 21:07
@martinvonz
Copy link
Member

Per project policy, please add your name to https://github.com/jj-vcs/jj/blob/main/docs/paid_contributors.md (can be done in this PR)

@martinvonz
Copy link
Member

@icorbrey: Is the failed CI another issue with PRs created against forks of the repo? I don't remember if the previous one that happened was fixed

Comment on lines +73 to +74
* `jj status` supports hiding the list of untracked files with flag `--hide-untracked`
and config option `ui.status-hide-untracked`.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I can see the use for the flag e.g. for scripting. When would one want the config? Why not add the paths to the .gitignore when you get tired or seeing them?

Copy link
Author

@tbodt tbodt Oct 21, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Honestly I only want the config :) I simply have such bad habits with leaving untracked files in my repo root that it is no longer by any stretch useful for me to see untracked files normally (in at least some of my projects...)

This implies needing another flag that's the inverse for when I do want to check on my untracked files.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hmm, a config for people with bad habits? :) I suppose if it's common that people have this bad habit, this might make sense.

Serious question: why do you keep those untracked files in your working copy instead of adding them to your .gitignore when you see them?

Copy link
Contributor

@PhilipMetzger PhilipMetzger left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I also don't understand the need for a config flag

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nit: can you add your primary motivation into the commits description and why you added a flag for it

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nit: squash this

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants