-
Notifications
You must be signed in to change notification settings - Fork 750
Add flag and setting to hide untracked files in jj status #7796
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The following commits do not follow our format for subject lines:
- dfbfe57: Add flag and setting to hide untracked files in jj status
Commits should have a subject line following the format <topic>: <description>
. Please review the commit guidelines for more information.
dfbfe57
to
fc95e74
Compare
All commits are now correctly formatted. Thank you for your contribution!
fc95e74
to
a2c390a
Compare
a2c390a
to
6544c83
Compare
Per project policy, please add your name to https://github.com/jj-vcs/jj/blob/main/docs/paid_contributors.md (can be done in this PR) |
@icorbrey: Is the failed CI another issue with PRs created against forks of the repo? I don't remember if the previous one that happened was fixed |
* `jj status` supports hiding the list of untracked files with flag `--hide-untracked` | ||
and config option `ui.status-hide-untracked`. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I can see the use for the flag e.g. for scripting. When would one want the config? Why not add the paths to the .gitignore
when you get tired or seeing them?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Honestly I only want the config :) I simply have such bad habits with leaving untracked files in my repo root that it is no longer by any stretch useful for me to see untracked files normally (in at least some of my projects...)
This implies needing another flag that's the inverse for when I do want to check on my untracked files.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hmm, a config for people with bad habits? :) I suppose if it's common that people have this bad habit, this might make sense.
Serious question: why do you keep those untracked files in your working copy instead of adding them to your .gitignore when you see them?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I also don't understand the need for a config flag
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
nit: can you add your primary motivation into the commits description and why you added a flag for it
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
nit: squash this
#7679
Checklist
If applicable:
CHANGELOG.md
README.md
,docs/
,demos/
)cli/src/config-schema.json
)