index: make Index commit ID resolution methods fallible
#7832
+90
−74
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bts
force-pushed
the
bts/fallible-commit-prefix
branch
2 times, most recently
from
1ff6768 to
092e0d5
Compare
This is part of a series of changes to make most methods on index traits (i.e. `ChangeIdIndex`, `MutableIndex`, `ReadonlyIndex`, `Index`) fallible. This will enable networked implementations of these traits, which may produce I/O errors during operation. See jj-vcs#7825 for more information.
This is part of a series of changes to make most methods on index traits (i.e. `ChangeIdIndex`, `MutableIndex`, `ReadonlyIndex`, `Index`) fallible. This will enable networked implementations of these traits, which may produce I/O errors during operation. See jj-vcs#7825 for more information.
bts
force-pushed
the
bts/fallible-commit-prefix
branch
from
092e0d5 to
36e0e90
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Context
This is part of a series of changes to make most methods on index traits (i.e.
ChangeIdIndex,MutableIndex,ReadonlyIndex,Index) fallible. The changes will enable networked implementations of these traits, which can produce I/O errors during operation. See #7825 for more information.This is a follow-up to #7799, #7823, and #7830.
Changes
These two changes convert the
Indextrait methodsshortest_unique_commit_id_prefix_lenandresolve_commit_id_prefixto returnIndexResult.