Skip to content

Conversation

@higgsd
Copy link
Contributor

@higgsd higgsd commented Oct 24, 2025

As noted by @yuja in #7808, --stdin tests should probably get newlines automatically.

Checklist

If applicable:

  • I have updated CHANGELOG.md
  • I have updated the documentation (README.md, docs/, demos/)
  • I have updated the config schema (cli/src/config-schema.json)
  • I have added/updated tests to cover my changes

@higgsd higgsd requested a review from a team as a code owner October 24, 2025 01:49
@higgsd higgsd force-pushed the push-pqpsprukqklz branch from 82042d0 to d45c8f8 Compare October 24, 2025 01:53
Copy link
Contributor

@yuja yuja left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks.

let mut buffer = String::new();
io::stdin().read_to_string(&mut buffer)?;
Some(buffer)
Some(complete_newline(buffer.as_str()))
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nit: remove .as_str()

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants