Skip to content

docs: use real world biome example#9112

Merged
martinvonz merged 1 commit intojj-vcs:mainfrom
fiws:docs-better-biome-example
Mar 14, 2026
Merged

docs: use real world biome example#9112
martinvonz merged 1 commit intojj-vcs:mainfrom
fiws:docs-better-biome-example

Conversation

@fiws
Copy link
Contributor

@fiws fiws commented Mar 14, 2026

The previous biome example in the docs was
not using a valid command and resulted in
the biome "--help" output being written to every file.

I also removed the windows version as there
seems to be a OS-agnostic binary now.


I was unsure why there is docs and web/docs … is one generated? anyway because this is a tiny change i just edited both.

The previous biome example in the docs was
not using a valid command and resulted in
the biome "--help" output being written to every file.

I also removed the windows version as there
seems to be a OS-agnostic binary now.
@fiws fiws requested a review from a team as a code owner March 14, 2026 19:39
@martinvonz
Copy link
Member

@jennings: Since it looks like you added the biome config in #7152, could you review this PR?

Copy link
Contributor

@jennings jennings left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks right to me!

I used the native binary directly because process spawning is so slow on Windows, and I like to avoid the cost of spawning node (which then just executes the native binary). But this is clearer.

I don’t know if eliding the “format” used to work, but I agree it should be there.

Copy link
Member

@martinvonz martinvonz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks

@martinvonz martinvonz added this pull request to the merge queue Mar 14, 2026
Merged via the queue into jj-vcs:main with commit b73e4d5 Mar 14, 2026
30 of 31 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants