tree_builder: make get_base_tree() concurrent and not recursive#9114
Merged
martinvonz merged 1 commit intomainfrom Mar 15, 2026
Merged
tree_builder: make get_base_tree() concurrent and not recursive#9114martinvonz merged 1 commit intomainfrom
martinvonz merged 1 commit intomainfrom
Conversation
yuja
approved these changes
Mar 15, 2026
martinvonz
force-pushed
the
mz/tkkwwuylsksl
branch
from
7a07a63 to
24c1866
Compare
We are seeing stack overflows in `get_base_trees()` at Google. This patch rewrites it to not be recursive and also read trees more concurrently by using a `FuturesUnordered`.
martinvonz
force-pushed
the
mz/tkkwwuylsksl
branch
from
24c1866 to
057e799
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
We are seeing stack overflows in
get_base_trees()at Google. This patch rewrites it to not be recursive and also read trees more concurrently by using aFuturesUnordered.Checklist
If applicable:
CHANGELOG.mdREADME.md,docs/,demos/)cli/src/config-schema.json)how it works, how it's organized), including any code drafted by an LLM.
an eye towards deleting anything that is irrelevant, clarifying anything
that is confusing, and adding details that are relevant. This includes,
for example, commit descriptions, PR descriptions, and code comments.