Dev #39
Merged
Dev #39
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
TableUI is now placed into an alternate screen buffer. This will help to preserve user's console history, particularly when resizing the console.
Always display the list of packages to be upgraded, and provide counts for both the number of upgrades available and the the number of packages selected to be updated.
Filter the progress output to remove undesired variability.
Added message when resolving an upgrade. This logic should no longer be utilized due to settings the console buffer width, but having a verbose message in case of a regression.
Added a progress indicator for Update-WinGetSoftware.
Function used an old variable name that was valid when the function was defined within the scope of another.
When completing arguments for the Update-WinGetSoftware "ID" parameter, previously entered IDs will be filtered from the available options.
The main benefit of this is to properly provide terminal-level busy indicators. Currently the winget command does not remain busy through the execution of the command. This commit works around this problem for consistency. A future update to winget may resolve this, in which case, this commit may be reverted. This commit also includes a delay for Merge-WinGetRestore. This is mostly for aesthetics and give the user time to see the output from the checkpoint command so it is not confused with some undesired error output. There may be room for improvement on the handling here.
After switching to the alternate screen buffer, the cursor does not appear to hide via the use of [Console]::CursorVisible = $false. Interestingly this issue can be resolved using the raw ANSI sequence for this operation. Along with this commit, a small tweak to the way the UI handles the user input to exit the package details screen. The key presses will now be cleared at the user types them.
Symlinks may not require admin if the user has been granted privileges in the security settings policies. The upgrade process for the module has replaced this check with a symlink creation test as a means to skip the request if it fails. There may be room to improve on this implementation; and in a future update it might be desirable to give users the option to mute warning messages.
Added a custom pager to help show package details in alternate buffer.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.