Fixes to JCAMP-DX FID handling #231
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
|
I think it would be better to have a complex data returned as is the case with most of the other formats. However, this change is backwards incompatible and will definitely break some existing code. I'll let @jjhelmus opine here. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR addresses issue #112 by adding a helper function get_complex_array to JCAMP-DX parser.
This can be used to combine the separate real and imaginary data arrays of a JCAMP FID to single array of complex data type.
However, if you suggest that this operation should be performed by default when encountering data with separate real and imaginary parts, I'm happy to edit this PR to that direction.
In addition, universal dictionary parameters "sw", "car", "time", "freq" and "complex" are now populated to the best effort (also in the case of FIDs), and tests for these are added (no additional test cases required).