Relax the peerDependency on @ember/test-waiters#36
Conversation
Hopefully fixes: jkeen#35 I'm surprised at how much stuff changed in `pnpn-lock.yaml` and I have no idea why. Also, I'm not entirely sure if this will do the trick because I can't get a local install of this package to work in my project. Something to do with a `yarn`/`pnpm` incompatibility that I don't know how to resolve.
WalkthroughUpdated ember-stereo/package.json to widen the peerDependency constraint for @ember/test-waiters from ^3.0.2 to ^3.0.2 || >= 4.0.0. No other files or exports were changed. Changes
Estimated code review effort🎯 1 (Trivial) | ⏱️ ~2 minutes Assessment against linked issues
Poem
Tip 🔌 Remote MCP (Model Context Protocol) integration is now available!Pro plan users can now connect to remote MCP servers from the Integrations page. Connect with popular remote MCPs such as Notion and Linear to add more context to your reviews and chats. ✨ Finishing Touches🧪 Generate unit tests
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. 🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
SupportNeed help? Create a ticket on our support page for assistance with any issues or questions. CodeRabbit Commands (Invoked using PR/Issue comments)Type Other keywords and placeholders
CodeRabbit Configuration File (
|
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
Actionable comments posted: 0
🧹 Nitpick comments (2)
ember-stereo/package.json (2)
94-94: Consider bounding to major v4 instead of open-ended >= 4.0.0Using ">= 4.0.0" will accept 5.x and beyond, which could introduce breakage without explicit validation. Other deps in this file follow the pattern "^X || ^Y" (e.g., ember-gesture-modifiers), so for consistency and safety, recommend "^3.0.2 || ^4.0.0" unless you’ve verified v5+ compatibility.
Proposed change:
- "@ember/test-waiters": "^3.0.2 || >= 4.0.0" + "@ember/test-waiters": "^3.0.2 || ^4.0.0"
91-96: Optionally mark the peer as optional to avoid warnings in consumers that don’t use itIf
@ember/test-waitersis only relevant in test environments, you can make the peer optional to reduce noise for consumers who don't install it.Suggested insertion after the peerDependencies block:
"peerDependencies": { "@babel/core": "^7.17.10", "@ember/string": ">=4", "@ember/test-waiters": "^3.0.2 || >= 4.0.0" }, + "peerDependenciesMeta": { + "@ember/test-waiters": { + "optional": true + } + },
📜 Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro
💡 Knowledge Base configuration:
- MCP integration is disabled by default for public repositories
- Jira integration is disabled by default for public repositories
- Linear integration is disabled by default for public repositories
You can enable these sources in your CodeRabbit configuration.
⛔ Files ignored due to path filters (1)
pnpm-lock.yamlis excluded by!**/pnpm-lock.yaml
📒 Files selected for processing (1)
ember-stereo/package.json(1 hunks)
⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (2)
- GitHub Check: Build Tests
- GitHub Check: Lint (./ember-stereo)
🔇 Additional comments (1)
ember-stereo/package.json (1)
94-94: Peer range relaxation looks correct and solves #35Widening to include 4.x+ resolves the "incorrect/unmet peer dependency" warnings reported.
2 participants
Hopefully fixes: #35
I'm surprised at how much stuff changed in
pnpn-lock.yamland I have no idea why.Also, I'm not entirely sure if this will do the trick because I can't get a local install of this package to work in my project. Something to do with a
yarn/pnpmincompatibility that I don't know how to resolve.Summary by CodeRabbit