Skip to content

fix: newline gets stripped if wrapper + secrets:// is used.#791

Merged
jkroepke merged 4 commits into
mainfrom
newline2
Jun 8, 2026
Merged

fix: newline gets stripped if wrapper + secrets:// is used.#791
jkroepke merged 4 commits into
mainfrom
newline2

Conversation

@jkroepke

@jkroepke jkroepke commented Jun 8, 2026

Copy link
Copy Markdown
Owner

What this PR does / why we need it:

Values with secrets:// are now passed to helm directly.

Which issue this PR fixes (optional, in fixes #<issue number>(, fixes #<issue_number>, ...) format, will close that issue when PR gets merged):

Special notes for your reviewer:

PR Readiness Checklist:

Complete these before marking the PR as ready to review:

  • the CHANGELOG.md release notes have been updated to reflect any significant (and particularly user-facing) changes introduced by this PR

Signed-off-by: Jan-Otto Kröpke <mail@jkroepke.de>
@codecov

codecov Bot commented Jun 8, 2026

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 86.46%. Comparing base (df76d46) to head (9e461a1).

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #791      +/-   ##
==========================================
+ Coverage   86.42%   86.46%   +0.04%     
==========================================
  Files          22       22              
  Lines         869      872       +3     
==========================================
+ Hits          751      754       +3     
  Misses        118      118              

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Signed-off-by: Jan-Otto Kröpke <mail@jkroepke.de>
jkroepke added 2 commits June 8, 2026 18:12
Signed-off-by: Jan-Otto Kröpke <mail@jkroepke.de>
Signed-off-by: Jan-Otto Kröpke <mail@jkroepke.de>
@jkroepke jkroepke enabled auto-merge (squash) June 8, 2026 16:23
@jkroepke jkroepke merged commit b64c329 into main Jun 8, 2026
22 checks passed
@jkroepke jkroepke deleted the newline2 branch June 8, 2026 16:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Newline gets stripped from last multiline secret

1 participant