-
Notifications
You must be signed in to change notification settings - Fork 517
Optimizations of L1 & L2 distance functors and miscellaneous improvements #277
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
revised unrolled loops in evalMetric() for L1/L2; added tests for L1
mainly inline & noexcept plus a few misc changes
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #277 +/- ##
==========================================
- Coverage 86.20% 84.25% -1.96%
==========================================
Files 1 1
Lines 667 705 +38
Branches 125 130 +5
==========================================
+ Hits 575 594 +19
- Misses 92 111 +19
🚀 New features to boost your workflow:
|
jlblancoc
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Awesome, thanks a lot! 👏
Please, see my minor comments above.
|
@mlourakis LGTM, thanks again for the contribution! On alignment: totally agree. Your comments are perfect as is now. |
|
Fully agree about autodetecting the HW details, that's one of the reasons I was reluctant to attempt it. But someone interested in getting the best possible performance, might choose to tweak alignment on his own machine. Thanks for your work on nanoflann! |
Revised the unrolled loops in L1 & L2 distance calculations (L[12]_Adaptor):
Additionally: