Add functionality to filter flame graphs by search query#503
Open
vivster7 wants to merge 1 commit intojlfwong:mainfrom
Open
Add functionality to filter flame graphs by search query#503vivster7 wants to merge 1 commit intojlfwong:mainfrom
vivster7 wants to merge 1 commit intojlfwong:mainfrom
Conversation
Author
|
@jack-mcivor I think so -- it matches against the frame's name, so if your frame contains the filename, you should be able to filter the "time order" and "left heavy" views by filename. I don't think this will do anything to the sandwich view though (which is maybe specifically what #468 was asking) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds a 🎯 button to the ctrl+f search bar that toggles an 'exact match' filter mode -- it only shows frames that exactly match the search query.
Personal.perf-vertx-stacks-01-collapsed-all.txt.-.speedscope.-.16.March.2025.mp4
This is one possible implementation for #192
The use case I was trying to support: simplify large call graphs into first party code vs specific third party libraries. Seems related to the following issues as well
Filtering the profile on keystroke feels like a fairly expensive operation, but I wasn't sure how else to implement. My fork solves my use case, but would be nice to upstream this feature if you'd accept this patch or a similar variant.