Skip to content

Add functionality to filter flame graphs by search query #503

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

vivster7
Copy link

@vivster7 vivster7 commented Mar 16, 2025

Adds a 🎯 button to the ctrl+f search bar that toggles an 'exact match' filter mode -- it only shows frames that exactly match the search query.

Personal.perf-vertx-stacks-01-collapsed-all.txt.-.speedscope.-.16.March.2025.mp4

This is one possible implementation for #192

The use case I was trying to support: simplify large call graphs into first party code vs specific third party libraries. Seems related to the following issues as well

Filtering the profile on keystroke feels like a fairly expensive operation, but I wasn't sure how else to implement. My fork solves my use case, but would be nice to upstream this feature if you'd accept this patch or a similar variant.

@jack-mcivor
Copy link

@vivster7 does this implement searching by filename #468 ?

I think that for my profile (Python code, generated with Autin) filtering by filename is the only way to achieve a distinction between first party code & specific third party libraries

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants