-
Notifications
You must be signed in to change notification settings - Fork 1.6k
Add loq file size limits and clean up type ignores #2859
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
Reduces function_tool.py from 595 to 413 lines, bringing it under the 500-line limit.
Adds loq to pre-commit hooks to track file sizes. Currently informational only - violations are shown but don't block commits.
ty and mcp library updates resolved the underlying type issues, making these suppression comments unnecessary.
|
Warning Rate limit exceeded@jlowin has exceeded the limit for the number of commits that can be reviewed per hour. Please wait 27 minutes and 12 seconds before requesting another review. ⌛ How to resolve this issue?After the wait time has elapsed, a review can be triggered using the We recommend that you space out your commits to avoid hitting the rate limit. 🚦 How do rate limits work?CodeRabbit enforces hourly rate limits for each developer per organization. Our paid plans have higher rate limits than the trial, open-source and free plans. In all cases, we re-allow further reviews after a brief timeout. Please see our FAQ for further information. ⛔ Files ignored due to path filters (22)
📒 Files selected for processing (27)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 54c1f3adc0
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
| - id: loq | ||
| name: loq (file size limits) | ||
| entry: uv run loq | ||
| entry: bash -c 'uv run loq || printf "\nloq violations not enforced... yet!\n"' |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Avoid bash-only pre-commit hook
The loq hook now runs bash -c ..., which requires a bash executable to be present. On Windows environments without Git Bash/WSL in PATH (a common default), pre-commit will fail with “executable bash not found” and block commits, whereas the previous uv run loq entry was cross‑platform. If you want a non‑blocking loq check, it needs a portable entry point (e.g., a small Python shim) rather than a bash shell dependency.
Useful? React with 👍 / 👎.
Adds file size enforcement via loq to help keep files manageable. Currently runs in pre-commit but doesn't block - just shows violations with a friendly reminder.
Also removes ~100 unused
# type: ignorecomments that were left over after mcp library type improvements.loq config highlights:
tests/**pattern for test files