Skip to content

feat: add chroot to make rm's relative to it#49

Open
milkpirate wants to merge 2 commits intojlumbroso:mainfrom
milkpirate:feat/clean-from-within-custom-container
Open

feat: add chroot to make rm's relative to it#49
milkpirate wants to merge 2 commits intojlumbroso:mainfrom
milkpirate:feat/clean-from-within-custom-container

Conversation

@milkpirate
Copy link

NOTE: please review carefully, I might have missed something!

Signed-off-by: Paul Schroeder <milkpirate@users.noreply.github.com>
@milkpirate milkpirate force-pushed the feat/clean-from-within-custom-container branch from 75ae52b to 63bd618 Compare January 11, 2026 14:52
@milkpirate milkpirate marked this pull request as draft January 11, 2026 14:53
@milkpirate milkpirate force-pushed the feat/clean-from-within-custom-container branch from 63bd618 to 4b976b8 Compare January 11, 2026 15:29
Signed-off-by: Paul Schroeder <milkpirate@users.noreply.github.com>
@milkpirate milkpirate force-pushed the feat/clean-from-within-custom-container branch from 4b976b8 to 6a931f2 Compare January 11, 2026 15:48
@milkpirate milkpirate marked this pull request as ready for review January 11, 2026 15:49
echo ""
df -h /
echo "$ dh -a /"
df -h ${{ inputs.chroot }}/
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

fwiw, passing inputs directly into the script is insecure - using intermediate env vars is considered a better practice 👉 https://docs.github.com/en/actions/reference/security/secure-use#use-an-intermediate-environment-variable

(also, seems like the repo owner isn't looking at any PRs, so this change might not get accepted 😞)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants