Skip to content

Conversation

@adamcandy
Copy link
Contributor

This caches the false states of 'prefer_english_names', which I expect is what was intended.
Fixes #371 (Geolocation examines config.ini for every new lookup).

@coveralls
Copy link

coveralls commented Apr 20, 2020

Coverage Status

Coverage decreased (-0.2%) to 90.877% when pulling aa02369 on adamcandy:prefer-english-names-optimize into 8e95b96 on jmathai:master.

@jmathai
Copy link
Owner

jmathai commented Apr 22, 2020

This looks good. Can you cherry pick the commits from #370 into this branch so we can combine them into a single PR?

@jmathai jmathai force-pushed the master branch 2 times, most recently from bbdb460 to ec11497 Compare October 29, 2025 05:11
@jmathai
Copy link
Owner

jmathai commented Oct 30, 2025

I wonder if we could just initialize __PREFER_ENGLISH_NAMES__ to False instead of None. I think that would have the same effect.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Geolocation examines config.ini for every new lookup

3 participants