-
-
Notifications
You must be signed in to change notification settings - Fork 143
Fixed docker #477
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Fixed docker #477
Conversation
|
Will nice in future add also a github action to create the image on ghcr |
Publishing on ghcr would be nice indeed |
|
I need to understand why the tests are failing - they shouldn't. |
|
I think if you rebase or merge from the master branch here then the tests will pass. |
You're right. I can't seem to get the environment variables exported for the tests. Let me dig a bit more. |
|
I suspect its due to pr is from fork? maybe just try and create local branch with the diff |
bbdb460 to
ec11497
Compare

Existing docker doesn't build, so I've fixed and provided small example on how to build and run