Open
Conversation
Include mkv in Video.extensions and extend video extension tests to cover it. (cherry picked from commit fc1099b6afe595d183b1dceaa594cf8b33ca92c6)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Adds
.mkvto supported video extensions.mkvtoVideo.extensionsinelodie/media/video.py.Testing and expectations
python3 -m pytest elodie/tests333 passed, 4 skipped, 1 xfailed(warnings only).python3 -m pytest elodie/tests/media/video_test.py -vNotes:
.mkvextension support + corresponding test update).pytestversions can differ on legacy tests in the base branch; this change does not modify those areas.