Skip to content

Fix geolocation fallback and stabilize offline test runs#523

Open
prodriguezxyz wants to merge 2 commits intojmathai:masterfrom
prodriguezxyz:review/analisis-inicial
Open

Fix geolocation fallback and stabilize offline test runs#523
prodriguezxyz wants to merge 2 commits intojmathai:masterfrom
prodriguezxyz:review/analisis-inicial

Conversation

@prodriguezxyz
Copy link
Copy Markdown

What changed

  • treat empty and placeholder MapQuest keys as unconfigured
  • fix prefer_english_names boolean parsing
  • update the README reference to issue #518
  • replace live MapQuest-dependent test behavior with deterministic offline fixtures
  • ignore venv/

Why

This fixes incorrect geolocation fallback behavior and makes the test suite reproducible
without external API access.

Validation

venv/bin/python -m pytest -q

- 338 passed, 13 skipped

@CLAassistant
Copy link
Copy Markdown

CLAassistant commented Mar 31, 2026

CLA assistant check
All committers have signed the CLA.

@prodriguezxyz prodriguezxyz force-pushed the review/analisis-inicial branch from 593b895 to 92eb6bf Compare March 31, 2026 10:00
@prodriguezxyz prodriguezxyz force-pushed the review/analisis-inicial branch from 92eb6bf to 0550a57 Compare March 31, 2026 10:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants