Skip to content

solarman_rtu_proxy.py: improve runtime stability #93

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
ngehrsitz wants to merge 2 commits into
base: main
Choose a base branch
from
Open

solarman_rtu_proxy.py: improve runtime stability #93

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
f72bb35
Exit for unhandled Exceptions
May 24, 2025
e3ab2ee
Switch docker base image to debian
May 29, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion Dockerfile
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,5 +1,6 @@
# syntax=docker/dockerfile:1
FROM python:3.13-alpine
# alpine causes issues with solarman_rtu_proxy.py: https://stackoverflow.com/a/77780983
FROM python:3.13-slim

# mount current directory to /app
# install with pip
Expand Down
7 changes: 6 additions & 1 deletion utils/solarman_rtu_proxy.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -15,6 +15,7 @@

import argparse
import asyncio
import sys
from functools import partial

from pysolarmanv5 import PySolarmanV5Async
Expand Down Expand Up @@ -93,7 +94,11 @@ def main():
)
args = parser.parse_args()

asyncio.run(run_proxy(args.bind, args.port, args.logger, args.serial))
try:
asyncio.run(run_proxy(args.bind, args.port, args.logger, args.serial))
except Exception as e:
print(f"Exception: {e}")
sys.exit(1)
Copy link
Copy Markdown
Contributor

@davidrapan davidrapan Jun 5, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is completely unnecessary call.

Copy link
Copy Markdown
Author

@ngehrsitz ngehrsitz Jun 5, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I also thaught that an expection should cause a crash of the script with a non-zero exit code.
But that was not the case, instead it kept prinitng the exception. I suspect this has something to do with how these scripts are made executable

pysolarmanv5/pyproject.toml

Lines 18 to 22 in 8b60764

[project.scripts]
solarman-decoder = "utils.solarman_decoder:main"
solarman-rtu-proxy = "utils.solarman_rtu_proxy:main"
solarman-scan = "utils.solarman_scan:main"
solarman-uni-scan = "utils.solarman_uni_scan:main"

Copy link
Copy Markdown
Contributor

@davidrapan davidrapan Jun 5, 2025 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hmmm.. 🤔



if __name__ == "__main__":
Expand Down