This repository was archived by the owner on Nov 4, 2023. It is now read-only.
Fix compiler errors introduced by newer compilers #10
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Rip out the gtest built in here. Use the system library. * Test against gtest-1.7.0-1 on Arch Linux * Add the missing -lpthread library
* These should be easily verified as correct. * Tested on gcc-5.2.0 and clang-3.6.2
* Never referenced and generate warnings on modern compilers * Tested on gcc-5.2.0 and clang-3.6.2
* Later versions of compilers/pre-processors are upset about the syntax * Bracket unterminated string with proper comment tags
* My compilers mark these as errors * Attempt to be more correct * Tested on gcc-5.2.0 and clang-3.6.2
* Return null when appropriate and assign a value earlier.
This was referenced Aug 18, 2015
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Build fails on my Arch Linux system with gcc-5.2.0 and clang-3.6.2.
Fixes:
All unit tests succeed for both compilers. 🎉