Skip to content

Conversation

@joeld1
Copy link

@joeld1 joeld1 commented Sep 26, 2023

In order to help in future-proofing this library and help in resolving and identifying bugs, I refactored method calls to use keyword arguments instead of positional arguments for method calls where keyword arguments could be easily deduced (i.e. deduced by name, is a remaining parameters).

Any arguments that lacked a variable name that matched the keyword argument name or couldn't be deduced were shifted to the left and left as positional arguments, all others were directly mapped.

… the gemini subpackage. Any arguments that lacked a variable name that matched the keyword argument name were shifted to the left and left as positional arguments, all others were directly mapped.
… the robinhood subpackage. Any arguments that lacked a variable name that matched the keyword argument name or couldn't be deduced were shifted to the left and left as positional arguments, all others were directly mapped.
… the tda subpackage. Any arguments that lacked a variable name that matched the keyword argument name or couldn't be deduced were shifted to the left and left as positional arguments, all others were directly mapped.
@joeld1
Copy link
Author

joeld1 commented Sep 26, 2023

Note, this entire process was done in PyCharm as follows:

  1. Change your PyCharm settings to show members in the file/project view.
    Screenshot 2023-09-26 at 1 54 10 PM

  2. Go through each file and find usages of each member
    Screenshot 2023-09-26 at 1 55 57 PM

  3. Go through each usage and map positional arguments to their appropriate keyword argument, any ambiguous positional arguments that I couldn't deduce or map were kept and shifted to the left.
    Screenshot 2023-09-26 at 1 57 41 PM

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant