robinhood/orders: document market_hours, correspond with extendedHours #454
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
add market_hours argument to relevant docstrings correct type hint for extendedHours from str to bool change market_hours to "extended_hours" if market hours unset and extendedHours is truthy
Owner
|
@doctorcolossus hello, can you please fix the merge conflicts, if they are still applicable. I merged some other branches. Trying to get to these changes so I an merge them all! |
Author
|
Hi @jmfernandes, sure, I'll see if I can find time to do this this weekend. |
|
any updates on this? @doctorcolossus |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
add market_hours argument to relevant docstrings
correct type hint for extendedHours from str to bool
change market_hours to "extended_hours" if market hours unset and extendedHours is truthy