Updated tests to support Windows.#77
Conversation
|
Couldn't you use 'npx spectral lint examples/valid/* -r ./.spectral.yml' which would also make sure that the dependent packages are installed before running the linter. Using either 'node_modules/.bin' or 'spectral' is making an assumption that the NPM package is already installed by the user. I'd suggest using 'npx spectral' in the test command instead of either of these approaches. |
fluffy-dutchman
left a comment
There was a problem hiding this comment.
See previous comment about using 'npx'
@tnederveld , Updated as suggested via dda130d . I've retested on Windows and Mac and both work OK with this modification. |
|
Thanks @tnederveld . I note that this PR is still stating it needs 1 approving review, from a reviewer with write access. Does this mean I need another review beyond yours? Do you have write access to this repository? @jmlue42 , could you please clarify? |
As per issue #75 , the existing test failed to run on Windows. The revised npm test command works on both Windows and Mac, as the removed text (node_modules/.bin) is automatically inserted at the beginning of the PATH before executing.