Skip tag creation for UUIDs, localnames and hostname

[javuto]

Implementation of #736 to skip automatic tag creation for UUIDs, localnames and hostnames.

[Copilot]

Pull Request Overview

This PR removes automatic tag creation for UUIDs, localnames, and hostnames, and surfaces a count of tagged nodes in the admin UI.

• Stop generating/handling tag types: uuid, localname, hostname (decorators, parsers, custom setters, CLI options, tests).
• Adjust auto-tagging to only use environment and platform.
• Add tagged-nodes count to the Tags page, including a new TagCounter type and CountTaggedNodes method.

Reviewed Changes

Copilot reviewed 7 out of 7 changed files in this pull request and generated 3 comments.

Show a summary per file

File	Description
pkg/tags/utils_test.go	Updates tests to align with removed tag types (uuid, localname).
pkg/tags/utils.go	Removes constants and switch cases for uuid/localname/hostname across helpers.
pkg/tags/tags.go	Adds TagCounter and CountTaggedNodes; fixes GetTaggedNodes query; limits AutoTagNode to env+platform.
cmd/cli/node.go	Removes CLI tag-type options for uuid, localname, hostname.
cmd/admin/templates/tags.html	Adds “Tagged Nodes” column; removes uuid/localname/hostname tag type options.
cmd/admin/handlers/types-templates.go	Adds CounterTags to template data.
cmd/admin/handlers/templates.go	Wires CountTaggedNodes into TagsGETHandler.

---

_{Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.}

[Copilot]

This implementation causes an N+1 query pattern by issuing one query per tag and loading full rows just to count. Replace with a single grouped COUNT query, e.g., select admin_tag_id, count(*) grouped by admin_tag_id, to populate TagCounter in one round-trip.

Suggested change

	for _, t := range tags {
	tagged, err := m.GetTaggedNodes(t)
	if err != nil {
	return tagCounter, err
	}
	tagCounter[t.ID] = len(tagged)
	if len(tags) == 0 {
	return tagCounter, nil
	}
	// Collect tag IDs
	tagIDs := make([]uint, len(tags))
	for i, t := range tags {
	tagIDs[i] = t.ID
	}
	// Result struct for query
	type result struct {
	AdminTagID uint
	Count int
	}
	var results []result
	// Grouped count query
	if err := m.DB.
	Model(&TaggedNode{}).
	Select("admin_tag_id, COUNT(*) as count").
	Where("admin_tag_id IN ?", tagIDs).
	Group("admin_tag_id").
	Scan(&results).Error; err != nil {
	return tagCounter, err
	}
	// Populate TagCounter from results
	for _, r := range results {
	tagCounter[r.AdminTagID] = r.Count
	}
	// Ensure all tags are present in the map (with zero if not found)
	for _, id := range tagIDs {
	if _, ok := tagCounter[id]; !ok {
	tagCounter[id] = 0
	}

[Copilot]

These magic numbers (0, 2, 4, 5, 6) must stay in sync with TagType constants. To avoid drift, consider exposing the numeric constants to the template data (e.g., map of name->value) and render options from that source.

[zhuoyuan-liu]

Great change! I think the documentation for tag cleanup is the only missing part.

[zhuoyuan-liu]

Should we remove these consnt as well?

// TagTypeEnv as tag type for environment name
	TagTypeEnv uint = 0
	// TagTypeUUID as tag type for node UUID
	TagTypeUUID uint = 1
	// TagTypePlatform as tag type for node platform
	TagTypePlatform uint = 2
	// TagTypeLocalname as tag type for node localname
	TagTypeLocalname uint = 3
	// TagTypeCustom as tag type for custom tags
	TagTypeCustom uint = 4
	// TagTypeUnknown as tag type for unknown tags
	TagTypeUnknown uint = 5
	// TagTypeTag as tag type for regular tags
	TagTypeTag uint = 6
	// TagTypeHostname as tag type for hostname tags
	TagTypeHostname uint = 7

[zhuoyuan-liu]

I have the same suggestion as Copilot: we should change it to use a single aggregate query.