Skip to content

Added test cases #614

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 3 commits into
base: master
Choose a base branch
from
Open
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Original file line number Diff line number Diff line change
@@ -0,0 +1,58 @@
package com.cronutils.descriptor.refactor;

import static org.junit.jupiter.api.Assertions.assertEquals;
import static org.junit.jupiter.api.Assertions.assertNotNull;
import static org.mockito.Mockito.mock;
import static org.mockito.Mockito.times;
import static org.mockito.Mockito.verify;

import java.util.Locale;
import java.util.ResourceBundle;

import org.junit.jupiter.api.BeforeEach;
import org.junit.jupiter.api.Test;

import com.cronutils.model.field.expression.And;
import com.cronutils.model.field.expression.Every;
import com.cronutils.model.field.expression.On;
import com.cronutils.model.field.value.IntegerFieldValue;

/**
* Test class for SecondsDescriptor.java
*/
class SecondsDescriptorTest {

ResourceBundle resourceBundle;
SecondsDescriptor secondsDescriptor;

@BeforeEach
public void setUp() {
resourceBundle = ResourceBundle.getBundle("com.cronutils.CronUtilsI18N", Locale.UK);
secondsDescriptor = new SecondsDescriptor(resourceBundle);
}

/**
* Test describe() method for 'And' field expression
*/
@Test
void testDescribeForAndExpression() {
String expectedDesc = "at 7 and 3";
And and = new And();
and.and(new On(new IntegerFieldValue(7)));
and.and(new On(new IntegerFieldValue(3)));
String description = secondsDescriptor.describe(and);
assertNotNull(description);
assertEquals(expectedDesc, description);
}

/**
* Test visit() method for 'Every' field expression
*/
@Test
void testVisitForEvery() {
SecondsDescriptor mockedDescriptor = mock(SecondsDescriptor.class);
Every every = new Every(new On(new IntegerFieldValue(7)), new IntegerFieldValue(2));
mockedDescriptor.visit(every);
verify(mockedDescriptor, times(1)).visit(every);
}
}
14 changes: 14 additions & 0 deletions src/test/java/com/cronutils/model/field/FieldParserTest.java
Original file line number Diff line number Diff line change
Expand Up @@ -18,6 +18,8 @@
import com.cronutils.parser.FieldParser;
import org.junit.jupiter.api.BeforeEach;
import org.junit.jupiter.api.Test;
import org.junit.jupiter.params.ParameterizedTest;
import org.junit.jupiter.params.provider.ValueSource;

import static org.junit.jupiter.api.Assertions.assertEquals;
import static org.junit.jupiter.api.Assertions.assertThrows;
Expand Down Expand Up @@ -100,4 +102,16 @@ public void testParseBetweenEveryX() {
public void testCostructorNullConstraints() {
assertThrows(NullPointerException.class, () -> new FieldParser(null));
}

/**
* Test parseOnWithLW() method for exception scenario
* @param expression Input parameters parse() method
*/
@ParameterizedTest
@ValueSource(strings = {"abLW", "LWlw", "1LW7"})
public void testParseOnWithLWForException(String expression) {
String exceptionMessage = String.format("Expected: LW, found: %s", expression.replace("LW", ""));
Exception exception = assertThrows(IllegalArgumentException.class, () -> parser.parse(expression));
assertEquals(exceptionMessage, exception.getMessage());
}
}
Original file line number Diff line number Diff line change
@@ -0,0 +1,55 @@
package com.cronutils.model.time;

import static com.cronutils.model.CronType.QUARTZ;
import static java.time.ZoneOffset.UTC;
import static org.junit.jupiter.api.Assertions.assertEquals;

import java.time.ZonedDateTime;
import java.util.ArrayList;
import java.util.List;
import java.util.Optional;

import org.junit.jupiter.api.BeforeEach;
import org.junit.jupiter.api.Test;

import com.cronutils.model.definition.CronDefinitionBuilder;
import com.cronutils.parser.CronParser;
/**
* Test for CompositeExecutionTime.java
*/
class CompositeExecutionTimeTest {

CompositeExecutionTime compositeExecutionTime;
CronParser parser;

@BeforeEach
public void setUp() {
CronParser parser = new CronParser(CronDefinitionBuilder.instanceDefinitionFor(QUARTZ));
List<ExecutionTime> executionTimes = new ArrayList<ExecutionTime>();
ExecutionTime executionTime = ExecutionTime.forCron(parser.parse("4 * * * * ? *"));
executionTimes.add(executionTime);
executionTime = ExecutionTime.forCron(parser.parse("6 0 0 * * ? *"));
executionTimes.add(executionTime);
compositeExecutionTime = new CompositeExecutionTime(executionTimes);
}

/**
* Test lastExecution() method
*/
@Test
void testLastExecution() {
ZonedDateTime dateTime = ZonedDateTime.of(2022, 10, 15, 3, 2, 4, 2, UTC);
Optional<ZonedDateTime> lastExecutionOptional = compositeExecutionTime.lastExecution(dateTime);
if(lastExecutionOptional.isPresent()) {
ZonedDateTime lastExecution = lastExecutionOptional.get();
assertEquals(dateTime.getYear(), lastExecution.getYear());
assertEquals(dateTime.getMonth(), lastExecution.getMonth());
assertEquals(dateTime.getDayOfMonth(), lastExecution.getDayOfMonth());
assertEquals(dateTime.getDayOfWeek(), lastExecution.getDayOfWeek());
assertEquals(dateTime.getHour(), lastExecution.getHour());
assertEquals(dateTime.getMinute(), lastExecution.getMinute());
assertEquals(dateTime.getSecond(), lastExecution.getSecond());
assertEquals(dateTime.getZone(), lastExecution.getZone());
}
}
}
21 changes: 21 additions & 0 deletions src/test/java/com/cronutils/parser/CronParserTest.java
Original file line number Diff line number Diff line change
Expand Up @@ -13,6 +13,7 @@

package com.cronutils.parser;

import com.cronutils.model.CompositeCron;
import com.cronutils.model.Cron;
import com.cronutils.model.CronType;
import com.cronutils.model.definition.CronDefinition;
Expand All @@ -23,11 +24,14 @@
import com.cronutils.model.field.definition.FieldDefinition;
import org.junit.jupiter.api.BeforeEach;
import org.junit.jupiter.api.Test;
import org.junit.jupiter.params.ParameterizedTest;
import org.junit.jupiter.params.provider.ValueSource;
import org.mockito.Mock;
import org.mockito.MockitoAnnotations;

import java.util.Collections;
import java.util.HashSet;
import java.util.List;
import java.util.Set;

import static org.junit.jupiter.api.Assertions.assertEquals;
Expand Down Expand Up @@ -220,4 +224,21 @@ public void testParseQuartzCronWithHash() {
parser = new CronParser(TestCronDefinitionsFactory.withDayOfYearDefinitionWhereYearAndDoYOptionals());
assertThrows(IllegalArgumentException.class, () -> parser.parse("0 0 0 ? * #"));
}

/**
* Test parse() method for composite cron expression (i.e. expression containing '||')
* @param expression Input parameters for parse() method
*/
@ParameterizedTest
@ValueSource(strings = {"2 0 0 1 * ? 2000 ? || 5 0 0 1 * ? 2017 ?", "5 3 0 ? * ? 1998 * || 1 0 0 ? * * 2023 ? || 3 3 * * * ? 2015 ?"})
public void testParseWithCompositeCron(String expression) {
parser = new CronParser(TestCronDefinitionsFactory.withDayOfYearDefinitionWhereYearAndDoYOptionals());
CompositeCron compositeCron = (CompositeCron) parser.parse(expression);
String[] expectedCrons = expression.split("\\|\\|");
List<Cron> crons = compositeCron.getCrons();
assertEquals(expectedCrons.length, crons.size());
for(int i = 0; i < crons.size(); i++) {
assertEquals(expectedCrons[i].trim(), crons.get(i).asString());
}
}
}