Add overlap detection for cron expressions #639
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This commit introduces a new `overlap` method to the `Cron` interface and its implementation in `SingleCron`. The `overlap` method allows checking if two cron expressions will have any common execution times. It works by: 1. Getting `ExecutionTime` instances for both cron expressions. 2. Defining a one-year window from the current time for the check. 3. Iterating through the execution times of the first cron within this window. 4. For each execution time, it checks if this time is a valid execution time for the second cron expression using `ExecutionTime.isMatch()`. Unit tests have been added in `SingleCronTest.java` to cover various scenarios, including: - The specific case from the motivating issue (daily vs. weekly at the same time). - Non-overlapping expressions. - Expressions overlapping on specific dates. - Always overlapping expressions (e.g., every minute). - Other edge cases to ensure robustness.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This commit introduces a new
overlapmethod to theCroninterface and its implementation inSingleCron.The
overlapmethod allows checking if two cron expressions will have any common execution times. It works by:ExecutionTimeinstances for both cron expressions.ExecutionTime.isMatch().Unit tests have been added in
SingleCronTest.javato cover various scenarios, including: