Add trailing clrf when building header for non-file parts. #833
+4
−2
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When building a `StreamingMultipartBody`, the following example shows the header for the `first_name` part should be followed by a clrf before the part's content starts. ==== Before ==== --test-boundary-123 Content-Disposition: form-data; name="avatar"; filename="tiny.gif" Content-Type: image/gif GIF89a,; --test-boundary-123 Content-Disposition: form-data; name="first_name" John --test-boundary-123 ==== After ==== --test-boundary-123 Content-Disposition: form-data; name="avatar"; filename="tiny.gif" Content-Type: image/gif GIF89a,; --test-boundary-123 Content-Disposition: form-data; name="first_name" John --test-boundary-123
|
Any chance this gets merged 🙏🏼 ? |
Contributor
Author
|
The CI build for 3.4 failed due to (I think) bad timing. The test diff shows the timestamp to be off by 1 second. 
Maybe rerun the CI to see if we get a green? |
|
is it possible to cut a release please @jnunemaker 🙏🏼 |
|
Waiting for it too. 🙏🏼 |
|
related #834 |
Owner
|
It's out. |
|
huzah! thanks @jnunemaker and @serixscorpio! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When building a
StreamingMultipartBody, the streaming body should produce same content as non-streamining. The following example shows the header for thefirst_namepart (a non-file part) is missing a clrf before the part's content starts. I think this explains the 400 error described in #832 .==== Before: no extra blank line between
"first_name"andJohn====The fix adds a trailing clrf to a non-file part's header:
==== After: notice the extra blank line between
"first_name"andJohn====The Before/After outputs are generated by adding
puts streaming_contentto the updatedstreaming body produces same content as non-streamingtest.