Draft
Conversation
…der token account
jnwng
force-pushed
the
jw/revoke-instruction
branch
from
d7a05a2 to
840c1f0
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
when interacting with a fairly stock auction created through the Metaplex UI, one operation consistently fails: placing bids. here's a transaction that fails to place a bid. the one instruction that fails is a "RevokeInstruction" that throws an error about an UninitializedAccount...
digging deeper, this RevokeInstruction is a "cleanup instruction" that is sent along with the approve instruction, with the
tokenAccountparameter. as of metaplex-foundation#1557, though, the tokenAccount here is a PDA instead of a user-created account.this is where things get slightly out of my wheelhouse — my first instinct is that it is not possible to revoke against a PDA, hence the fix here which skips the revocation instruction entirely (fwiw, after doing that, all the operations including placing a bid / withdrawing items work as expected). OTOH, it is plausible that there's something missing in the bidder pot initialization process, too, which could also cause the revocation failure. i am unsure!