Skip to content

Time struct comparison #264

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

rahulDNS
Copy link

@rahulDNS rahulDNS commented May 7, 2025

No description provided.

@rahulDNS
Copy link
Author

rahulDNS commented May 7, 2025

"This PR adds a comparison for time struct formats. Let me know if any revisions are needed. Thanks!"

@joaomatossilva
Copy link
Owner

Please fix the indentation

@joaomatossilva
Copy link
Owner

and the compilation errors, while at it

@@ -114,6 +114,33 @@ public int CompareTo(Time other)
return hoursDiff;
}

public override bool Equals(object obj)

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You're adding all of these methods in the wrong place, inside the CompareTo method. Move it outside of that method and fix the indentation.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants