Skip to content
Open
Show file tree
Hide file tree
Changes from 8 commits
Commits
Show all changes
27 commits
Select commit Hold shift + click to select a range
28bd246
Sketch of determine_api_scope.
itamarst Jun 23, 2026
128c4ef
Add API scope to info.
itamarst Jun 23, 2026
8637248
Reformat
itamarst Jun 23, 2026
6946867
Reformat.
itamarst Jun 23, 2026
31bbcf5
Try to work with older Python.
itamarst Jun 23, 2026
f27e6f2
Better names.
itamarst Jun 23, 2026
0d4dde5
Test for expected API scopes for different libraries.
itamarst Jun 23, 2026
60dd11c
Be more lenient.
itamarst Jun 23, 2026
2c985b6
Convert into test to check _determine_api_scope(), rather than of exp…
itamarst Jun 30, 2026
bb7b528
Don't include API scope in info by default, since it might have side-…
itamarst Jun 30, 2026
7fee2dc
Minor cleanups.
itamarst Jun 30, 2026
1c6ae79
Improve docs.
itamarst Jun 30, 2026
9ad8382
Match command-line behavior
itamarst Jun 30, 2026
d306c55
Give up on live testing, it's too inconsistent.
itamarst Jun 30, 2026
8740d13
Cleanups from code review
itamarst Jul 1, 2026
12a9d96
Review comments: better names, don't raise exception.
itamarst Jul 1, 2026
95d77a0
Try to reintroduce a test that checks real libraries.
itamarst Jul 1, 2026
3c831ad
Better explanation.
itamarst Jul 2, 2026
db35024
There's another option
itamarst Jul 6, 2026
b076937
Document better the limitations of this parameter.
itamarst Jul 6, 2026
a686a9b
Correct filtering logic.
itamarst Jul 6, 2026
fa3be78
Black
itamarst Jul 6, 2026
0e44183
New architecture that showed up from a CI run
itamarst Jul 6, 2026
586809d
FlexiBLAS support.
itamarst Jul 6, 2026
5899f47
Correct default
itamarst Jul 6, 2026
8d6bee5
Add changelog entry
itamarst Jul 8, 2026
3bc6b79
Explanatory comment.
itamarst Jul 8, 2026
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
51 changes: 51 additions & 0 deletions tests/test_api_introspection.py
Original file line number Diff line number Diff line change
@@ -0,0 +1,51 @@
"""
Tests for get/set number of threads API introspection.
"""

from threading import local as threadlocal

import pytest

from threadpoolctl import _APIScope, _determine_api_scope


class FakeThreadLocalAPI(threadlocal):
"""Thread-local num threads setting API."""

def get(self) -> int:
return getattr(self, "num_threads", 17)

def set(self, n: int) -> None:
self.num_threads = n


class FakeProcesswideAPI:
"""Process-wide num threads setting API."""

def __init__(self, num_threads: int):
self.num_threads = num_threads

def get(self) -> int:
return self.num_threads

def set(self, n: int) -> None:
self.num_threads = n


def test_determine_api_scope_thread_local():
"""
Check ``_determine_api_scope()`` can correctly diagnose a trivial
thread-local implementation.
"""
api = FakeThreadLocalAPI()
assert _determine_api_scope(api.get, api.set) == _APIScope.CURRENT_THREAD


@pytest.mark.parametrize("default", [1, 17])
def test_determine_api_scope_processiwde(default: int):
"""
Check ``determine_api_scope()`` can correctly diagnose a trivial
process-wide implementation.
"""
api = FakeProcesswideAPI(default)
assert _determine_api_scope(api.get, api.set) == _APIScope.PROCESS
23 changes: 23 additions & 0 deletions tests/test_threadpoolctl.py
Original file line number Diff line number Diff line change
@@ -1,3 +1,5 @@
from __future__ import annotations

import json
import os
import pytest
Expand Down Expand Up @@ -792,3 +794,24 @@ def test_custom_controller():
assert mylib_controller.num_threads == 1

assert ThreadpoolController().info() == original_info


@pytest.mark.parametrize(
["select_filter", "expected_api_scope"],
[
({"internal_api": "openblas"}, "process"),
({"internal_api": "mkl"}, "process"),
({"internal_api": "blis"}, "process"),
Comment thread
itamarst marked this conversation as resolved.
Outdated
({"user_api": "openmp"}, "current_thread"),
],
)
def test_api_scope(select_filter: dict[str, str], expected_api_scope: str) -> None:
"""
For the given controller, expect the given API scope.
"""
controller = ThreadpoolController().select(**select_filter)
if not controller.lib_controllers:
pytest.skip(f"{select_filter} controller not found")

for lib in controller.lib_controllers:
assert lib.info()["api_scope"] == expected_api_scope
92 changes: 91 additions & 1 deletion threadpoolctl.py
Original file line number Diff line number Diff line change
Expand Up @@ -17,12 +17,14 @@
import ctypes
import itertools
import textwrap
from typing import final
from threading import Thread
from typing import Callable, final
import warnings
from ctypes.util import find_library
from abc import ABC, abstractmethod
from functools import lru_cache
from contextlib import ContextDecorator
from enum import Enum, auto

__version__ = "3.7.0.dev0"
__all__ = [
Expand Down Expand Up @@ -69,6 +71,89 @@ class _dl_phdr_info(ctypes.Structure):
_RTLD_NOLOAD = ctypes.DEFAULT_MODE


class _APIScope(Enum):
Comment thread
itamarst marked this conversation as resolved.
Outdated
"""
What scope does the API affect.
"""

# Using the API sets a limit only on the current thread.
CURRENT_THREAD = auto()
# Using the API sets a limit for every thread in the process; whether or
# not it's a shared process-wide pool or per-thread limit needs to be
# determined some other way.
PROCESS = auto()
# Something else, unexpected; perhaps another variant, perhaps information
# can't be determined under the current configuration.
UNKNOWN = auto()


def _determine_api_scope(
get_n_threads: Callable[[], int], set_n_threads: Callable[[int], None]
) -> _APIScope:
"""
Run some experiments to determine the scope of the given get/set API.

An attempt will be made to restore all settings to their previous state.

This won't work if you only have one core available.
Comment thread
itamarst marked this conversation as resolved.
Outdated
"""
if os.cpu_count() == 1 or (
hasattr(os, "process_cpu_count") and os.process_cpu_count() == 1
):
raise RuntimeError("Cannot determine API meaning if only one core is available")
Comment thread
itamarst marked this conversation as resolved.
Outdated

previous = get_n_threads()

# Some plausible constraints we need to keep in mind:
#
# 1. The API might not allow setting more than the number of (available, or
# physical) cores.
# 2. ...
try:
# Choose a desired number of threads that is different than the current
# number, and hopefully achievable under the current configuration:
if previous < 2:
expected = 2
Comment thread
itamarst marked this conversation as resolved.
else:
# It's 2 or more, so shrink it slightly:
expected = previous - 1

thread_result = []

def get_and_set() -> None:
set_n_threads(expected)
thread_result.append(get_n_threads())

thread = Thread(target=get_and_set)
thread.start()
thread.join()

# First, getting in the same thread as a set should always give same
# number, if it's a number in a reasonable range. A possible exception
# is if the number of thread is limited by available CPU, and only one
# CPU is available. In that case we can't empirically determine how the
# API works. We try to not reach that point here, but you can imagine a
# thread pool implementation that is aware of cgroups, in which case a
# Docker container limited to one core will pass the safety check at
# the start of the function. Perhaps cpu_count() from loky should be
# moved into this package...
Comment thread
itamarst marked this conversation as resolved.
Outdated
if thread_result != [expected]:
return _APIScope.UNKNOWN

# Now, check this thread:
if get_n_threads() == expected:
# Setting modified this thread's results too:
return _APIScope.PROCESS
elif get_n_threads() == previous:
# Setting modified the other thread, but not this one:
return _APIScope.CURRENT_THREAD
else:
# No idea what's going on:
return _APIScope.UNKNOWN
finally:
set_n_threads(previous)


class LibController(ABC):
"""Abstract base class for the individual library controllers

Expand Down Expand Up @@ -123,6 +208,11 @@ def info(self):
"user_api": self.user_api,
"internal_api": self.internal_api,
"num_threads": self.num_threads,
"api_scope": (
_determine_api_scope(
self.get_num_threads, self.set_num_threads
).name.lower()
),
**{k: v for k, v in vars(self).items() if k not in hidden_attrs},
}

Expand Down
Loading