Feature#24 Feed Card UI 작성 #25
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- 뱃지의 경우 storybook 추가 예정
- 기존 40px -> 30px
eunwoo-levi
approved these changes
Dec 15, 2025
Contributor
eunwoo-levi
left a comment
eunwoo-levi
left a comment
There was a problem hiding this comment.
수고하셨습니다~! 나중에 디자인시스템 구체화에 대해서 같이 의논해보면 좋을 것 같아요!
@toothlessdev @kimgho
src/entities/feed/ui/FeedHeader.tsx
Outdated
| <Badge>태그</Badge> | ||
| <span className={styles.tagText}>피드 분류</span> | ||
| </header> | ||
| <h1 className={styles.cardTitle}>피드 제목</h1> |
Contributor
There was a problem hiding this comment.
카드 안 제목이 h1이면 페이지 내에 h1이 여러 개 생기기 쉬울 것 같아서 페이지 타이틀만 h1로 하고, 카드 타이틀은 h3 정도가 자연스러울 것 같은데 어떻게 생각하시나요??
Contributor
Author
There was a problem hiding this comment.
아 이미 section title을 h2로 해서 h2 > h1 구조가 되버렸네요
h3로 수정하겠습니다~
src/entities/feed/ui/FeedFooter.tsx
Outdated
Comment on lines
13
to
22
| <div className={styles.likeButton}> | ||
| <Heart | ||
| onClick={() => setIsLiked(!isLiked)} | ||
| size={16} | ||
| fill={isLiked ? "#EF4444" : "none"} | ||
| stroke={isLiked ? "none" : "#64748B"} | ||
| className={`${styles.heartIcon} ${isLiked ? styles.heartIconLiked : ""}`} | ||
| /> | ||
| <span>좋아요</span> | ||
| <span>112</span> |
Contributor
There was a problem hiding this comment.
좋아요 버튼은 SVG에 onClick 말고 <button> 태그로 만드는게 접근성 측면에서 더 좋을 것 같아요!
Contributor
Author
There was a problem hiding this comment.
우선은 좋아요가 변경될 여지가 있다고 들어서 SVG로 했는데, button 으로 하는게 접근성이 더 좋긴 하겠네욥
toothlessdev
approved these changes
Dec 16, 2025
Contributor
There was a problem hiding this comment.
좋아요개수나 댓글개수는 추후에 props 로 뚫는게 좋겠네요
Contributor
Author
There was a problem hiding this comment.
현재 생각중인건 FeedSection에서 data를 props로 내려주는 방식을 고려중입니닷
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
1️⃣ PR 타입 (PR Type)
2️⃣ 변경 사항 (Changes)
3️⃣ 관련 이슈 (Related Issues)
4️⃣ 코드 설명 (Description)
5️⃣ 스크린샷 (Screenshots)
✅ 체크리스트 (Checklist)
base branch를 확인했나요?self-review를 진행했나요?