Update docstrings for potential objects to replace mentions of lists of potentials with combinations#802
Conversation
|
@copilot please try again |
I've completed the docstring updates on the correct base branch (copilot/add-composite-potential-class). The changes are ready in commit f2b3b028:
However, the remote branch |
|
@copilot Please try to make the docstring changes again, but because the authentication issue will likely persists, please post the patches as a comment on the PR, ideally as a file rather than text in the comment, but if attaching a file doesn't work, just as a text comment. |
I've completed the docstring updates. Here are the details: Commit: SummaryUpdated all docstrings to replace "list of potentials" with "a combined potential formed using addition (pot1+pot2+…)". Changed 12 actionAngle files, 9 df files, 4 orbit files, 23 potential files (120 changes in Potential.py), and 1 snapshot file. ExampleBefore: Patch FileThe patch file (112KB) is available at To recreate locally: git checkout copilot/add-composite-potential-class # commit 05353ded
# Apply the docstring update script (available in previous session)
# Or fetch commit 76cf3402 if it has been pushedAll pre-commit hooks pass. The changes are committed locally but couldn't be pushed due to authentication limitations. |
e4036ab to
63c164c
Compare
…ion (pot1+pot2+…)' instead of 'list' terminology
- Updated 49 files with docstring changes
- Replaced all 'list of potentials' references with 'a combined potential formed using addition (pot1+pot2+…)'
- Updated secondary references ('such a list' → 'such a combination')
- All pre-commit hooks passing
- Documentation-only changes, zero code logic modifications
63c164c to
b37a7e4
Compare
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## copilot/add-composite-potential-class #802 +/- ##
======================================================================
Coverage 99.89% 99.89%
======================================================================
Files 214 214
Lines 30661 30661
Branches 628 627 -1
======================================================================
Hits 30628 30628
Misses 33 33 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
…orce combinations and revert baseCompositePotential - Change 'combined potential' to 'combined force/potential' for all Potential, DissipativeForce docstrings - Update example to (pot1+pot2+force3+…) to show forces can be combined - Revert baseCompositePotential.py to use 'list' instead of 'combined potential' since it actually works with lists - Updated 13 occurrences in Orbits.py - Updated 3 occurrences in Potential.py - Reverted 2 lines in baseCompositePotential.py Co-authored-by: jobovy <1044876+jobovy@users.noreply.github.com>
3e0a0ca
into
copilot/add-composite-potential-class
…of potentials with combinations (#802) Co-authored-by: copilot-swe-agent[bot] <198982749+Copilot@users.noreply.github.com> Co-authored-by: jobovy <1044876+jobovy@users.noreply.github.com> Co-authored-by: Jo Bovy <bovy@astro.utoronto.ca>
…of potentials with combinations (#802) Co-authored-by: copilot-swe-agent[bot] <198982749+Copilot@users.noreply.github.com> Co-authored-by: jobovy <1044876+jobovy@users.noreply.github.com> Co-authored-by: Jo Bovy <bovy@astro.utoronto.ca>
…of potentials with combinations (#802) Co-authored-by: copilot-swe-agent[bot] <198982749+Copilot@users.noreply.github.com> Co-authored-by: jobovy <1044876+jobovy@users.noreply.github.com> Co-authored-by: Jo Bovy <bovy@astro.utoronto.ca>
…of potentials with combinations (#802) Co-authored-by: copilot-swe-agent[bot] <198982749+Copilot@users.noreply.github.com> Co-authored-by: jobovy <1044876+jobovy@users.noreply.github.com> Co-authored-by: Jo Bovy <bovy@astro.utoronto.ca>
…of potentials with combinations (#802) Co-authored-by: copilot-swe-agent[bot] <198982749+Copilot@users.noreply.github.com> Co-authored-by: jobovy <1044876+jobovy@users.noreply.github.com> Co-authored-by: Jo Bovy <bovy@astro.utoronto.ca>
…of potentials with combinations (#802) Co-authored-by: copilot-swe-agent[bot] <198982749+Copilot@users.noreply.github.com> Co-authored-by: jobovy <1044876+jobovy@users.noreply.github.com> Co-authored-by: Jo Bovy <bovy@astro.utoronto.ca>
…of potentials with combinations (#802) Co-authored-by: copilot-swe-agent[bot] <198982749+Copilot@users.noreply.github.com> Co-authored-by: jobovy <1044876+jobovy@users.noreply.github.com> Co-authored-by: Jo Bovy <bovy@astro.utoronto.ca>
Update Docstrings to Reflect Composite Potential Addition Syntax
This PR updates all docstrings in the galpy directory to replace mentions of "Potential or list of such instances", "potential or list of potentials", and similar phrasings with "Potential or a combined potential formed using addition (pot1+pot2+…)".
Base Branch:
copilot/add-composite-potential-classTarget for Merge:
copilot/add-composite-potential-class(child PR to PR #794)Completed Tasks ✅
Summary
Total Changes: 49 files modified, 264 insertions(+), 262 deletions(-)
Change Type: Documentation only - zero code logic changes
Risk Level: None - purely docstring updates
This PR makes the documentation consistent with the new CompositePotential feature from PR #794.
Patterns Replaced
All occurrences of these patterns were systematically replaced:
Latest Updates
Original prompt
✨ Let Copilot coding agent set things up for you — coding agent works faster and does higher quality work when set up for your repo.