Update vendored xsf from v0.1.3 to v0.2.0#843
Merged
Conversation
Copilot created this pull request from a session on behalf of
jobovy
March 27, 2026 01:34
View session
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #843 +/- ##
=======================================
Coverage 99.91% 99.91%
=======================================
Files 221 221
Lines 31877 31877
Branches 662 662
=======================================
Hits 31850 31850
Misses 27 27 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
jobovy
approved these changes
Mar 27, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Updates the vendored xsf library (SciPy's special functions) from v0.1.3 to v0.2.0, focusing only on the files required for galpy's usage of xsf (the
hyp2f1hypergeometric function used inTwoPowerSphericalPotentialandTwoPowerTriaxialPotential).Changes
Only 4 of the 25 vendored files changed between v0.1.3 and v0.2.0 (verified by comparing git blob SHAs). The changes are:
xsf/include/xsf/hyp2f1.h— Adds NaN input check (scipy/xsf#95): Returns NaN immediately when any input argument is NaN.xsf/include/xsf/cephes/const.h— Fixes incorrect constant values/names (scipy/xsf#100):SQRT2PIfrom0.79788...(wrong: that's sqrt(2/pi)) to2.5066...(correct: sqrt(2*pi))SQRTPIconstant (which was actually sqrt(2*pi))LOGSQRT2PIcommentxsf/include/xsf/cephes/gamma.h— Updates to use renamedSQRT2PIconstant (one-line change, consequence of theconst.hfix).xsf/include/xsf/cephes/hyp2f1.h— Adds special case fora == -1(scipy/xsf#85), fixing incorrect results for that input.Testing
TwoPowerSphericalPotentialfunctionality verifiedSecurity Summary: No security vulnerabilities found (CodeQL scan: 0 alerts).