FIX #641: GitHub Calender working properly #658
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- added react-github-calender - removed github-calender
- removed old manual import of css files for github-calender - added GitHubCalender component from react-github-calender and setup username prop
- react-github-calender uses it's own css so removing manual css. - it is written in typescript, so removing unused module declaration.
AdityaMayukhSom
changed the title
AdityaMayukhSom
changed the title
Author
|
@joelshepherd Could you please give any updates regarding the bug with GitHub calendar? |
|
Yeah, please. |
|
@joelshepherd please can you merge this? |
szamanr
approved these changes
Jul 25, 2024
szamanr
left a comment
szamanr
left a comment
There was a problem hiding this comment.
looks good to me! 👍 though i would remove the old code instead of commenting.
@joelshepherd could you merge this?
szamanr
suggested changes
Jul 25, 2024
szamanr
left a comment
szamanr
left a comment
There was a problem hiding this comment.
actually, it doesn't run, because the previous dependency is still being referenced as a css import.
|
i fixed it here for tab nine, which is a fork of tabliss. seems like this repo is inactive, while tab nine is more actively maintained. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request is a fix to the issues #641.
The old github-calender package hasn't been updated in the last 2 years and it lacks proper documentation too. Hence I submit a pull request with minimal changes introducing a react based GitHub calendar library named react-github-calender. This library is well documented (documentation) and if updated regularly.
Current new tab with light theme looks like -
Introducing this library reduces -
Note: This pull request also fixes a TypeError in storage.ts file for a
setTimeoutfunction.