Skip to content

Add validation for response body && api key check #681

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Add validation for response body && api key check #681

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
29 changes: 18 additions & 11 deletions src/plugins/backgrounds/unsplash/api.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -20,6 +20,10 @@ export const fetchImages = async ({
Authorization: `Client-ID ${UNSPLASH_API_KEY}`,
});

if (!UNSPLASH_API_KEY) {
throw new Error("You must set the UNSPLASH_API_KEY environment variable.");
}

params.set("count", "10");

switch (by) {
Expand All @@ -45,17 +49,20 @@ export const fetchImages = async ({
const res = await fetch(`${url}?${params}`, { headers, cache: "no-cache" });
const body = await res.json();

// TODO: validate types

return body.map((item: any) => ({
src: item.urls.raw,
credit: {
imageLink: item.links.html,
location: item.location ? item.location.name : null,
userName: item.user.name,
userLink: item.user.links.html,
},
}));
if (Array.isArray(body)) {
return body.map((item: any) => ({
src: item.urls.raw,
credit: {
imageLink: item.links.html,
location: item.location ? item.location.name : null,
userName: item.user.name,
userLink: item.user.links.html,
},
}));
} else {
console.error('Expected an array, but received:', body);
return [];
}
};

/**
Expand Down